-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make case title description explicitly configurable from the source ZGW fields #1573
Conversation
c978fe7
to
e976b23
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1573 +/- ##
===========================================
- Coverage 94.23% 94.21% -0.02%
===========================================
Files 1073 1074 +1
Lines 39578 39621 +43
===========================================
+ Hits 37297 37330 +33
- Misses 2281 2291 +10 ☔ View full report in Codecov by Sentry. |
ddaf886
to
0a6f9b3
Compare
e1df3eb
to
e779539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the label for the first option in the new Enum is misleading and should be changed, unless I'm misunderstanding the current title/description situation.
...er/openzaak/migrations/0060_remove_openzaakconfig_use_zaak_omschrijving_as_title_and_more.py
Outdated
Show resolved
Hide resolved
...er/openzaak/migrations/0060_remove_openzaakconfig_use_zaak_omschrijving_as_title_and_more.py
Outdated
Show resolved
Hide resolved
f3a0af0
to
96b221f
Compare
96b221f
to
598d211
Compare
Taiga 2950
Now that there's three options, rather than two, to configure how a case title is displayed, the
use_zaak_omschrijving_as_title
flag has been deprecated in favor of an explicit enum:As @alextreme pointed out earlier, this should really be a flag configurable on each individual API group rather than globally, but TLDR, that's a much larger refactor than it looks like, so we'll have to do that another day.