Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make case title description explicitly configurable from the source ZGW fields #1573

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Jan 22, 2025

Taiga 2950

Now that there's three options, rather than two, to configure how a case title is displayed, the use_zaak_omschrijving_as_title flag has been deprecated in favor of an explicit enum:

Screenshot from 2025-01-22 15-55-12

As @alextreme pointed out earlier, this should really be a flag configurable on each individual API group rather than globally, but TLDR, that's a much larger refactor than it looks like, so we'll have to do that another day.

@swrichards swrichards force-pushed the 2950-use-zaaktype-naam-as-omschrijving branch 5 times, most recently from c978fe7 to e976b23 Compare January 22, 2025 14:27
@swrichards swrichards marked this pull request as ready for review January 22, 2025 14:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes missing coverage. Please review.

Project coverage is 94.21%. Comparing base (7a79e99) to head (598d211).

Files with missing lines Patch % Lines
...kconfig_use_zaak_omschrijving_as_title_and_more.py 70.83% 7 Missing ⚠️
src/open_inwoner/openzaak/api_models.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1573      +/-   ##
===========================================
- Coverage    94.23%   94.21%   -0.02%     
===========================================
  Files         1073     1074       +1     
  Lines        39578    39621      +43     
===========================================
+ Hits         37297    37330      +33     
- Misses        2281     2291      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the 2950-use-zaaktype-naam-as-omschrijving branch 2 times, most recently from ddaf886 to 0a6f9b3 Compare January 22, 2025 15:01
@swrichards swrichards requested a review from pi-sigma January 22, 2025 15:33
@swrichards swrichards force-pushed the 2950-use-zaaktype-naam-as-omschrijving branch 2 times, most recently from e1df3eb to e779539 Compare January 22, 2025 16:37
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the label for the first option in the new Enum is misleading and should be changed, unless I'm misunderstanding the current title/description situation.

@swrichards swrichards force-pushed the 2950-use-zaaktype-naam-as-omschrijving branch 2 times, most recently from f3a0af0 to 96b221f Compare January 23, 2025 10:57
@swrichards swrichards force-pushed the 2950-use-zaaktype-naam-as-omschrijving branch from 96b221f to 598d211 Compare January 23, 2025 11:20
@swrichards swrichards requested a review from pi-sigma January 23, 2025 15:44
@swrichards swrichards requested a review from alextreme January 23, 2025 16:20
@alextreme alextreme merged commit 1d57159 into develop Jan 23, 2025
22 checks passed
@alextreme alextreme deleted the 2950-use-zaaktype-naam-as-omschrijving branch January 23, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants