[#2959] Sync user to eSuite after completing registration #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
2959-sync-user-to-esuite-post-registration
branch
from
fbd687c to
8fe71fd
Compare
swrichards
changed the title
swrichards
commented
Jan 15, 2025
| @@ -89,38 +89,6 @@ def _update_eherkenning_user_from_kvk_api(user: User): | |||
| user.save() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@pi-sigma Note here that this hook did not add much: all DigiD/eHerkenning users would also be logged in upon creation, which would trigger the handler for the user_logged_in flow, so I removed this as it just causes confusion.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1553 +/- ##
========================================
Coverage 94.23% 94.23%
========================================
Files 1068 1068
Lines 39348 39385 +37
========================================
+ Hits 37080 37115 +35
- Misses 2268 2270 +2 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Jan 15, 2025
swrichards
force-pushed
the
2959-sync-user-to-esuite-post-registration
branch
from
8fe71fd to
7b59861
Compare
swrichards
force-pushed
the
2959-sync-user-to-esuite-post-registration
branch
from
7b59861 to
72f8e8a
Compare
|
Will merge to ensure we can test this today before the esuite is closed off end-of-day... but I'll only trust this after I see it working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga