eSuite user syncing refactors #1546
Open
+450
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
2059-sync-user-to-klant-systeem-on-create
branch
from
ac63e0f to
ed85115
Compare
swrichards
force-pushed
the
2059-sync-user-to-klant-systeem-on-create
branch
from
ed85115 to
928216d
Compare
swrichards
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1546 +/- ##
===========================================
+ Coverage 94.13% 94.24% +0.11%
===========================================
Files 1064 1065 +1
Lines 39302 39313 +11
===========================================
+ Hits 36997 37052 +55
+ Misses 2305 2261 -44 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Jan 10, 2025
| voorvoegselAchternaam: str | ||
| achternaam: str | ||
| class KlantWritePayload(TypedDict, total=False): | ||
| """The writable fields for en eSuite klant. |
There was a problem hiding this comment.
Suggested change
| """The writable fields for en eSuite klant. | |
| """The writable fields for an eSuite klant. |
| voornaam: str | ||
| voorvoegselAchternaam: str | ||
| achternaam: str | ||
| class KlantWritePayload(TypedDict, total=False): |
There was a problem hiding this comment.
Perhaps the name itself (not just the comment) should make clear that this is intended for eSuite: KlantWritePayloadESuite or the like?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ground-clearing in preparation for a PR to actually sync new user data to eSuite upon user creation.