Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2808] Use KVK API to check legal status of compay at login #1544

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Jan 8, 2025

@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch 4 times, most recently from dc8339d to 187870b Compare January 10, 2025 14:44
@pi-sigma pi-sigma changed the title [#2808] Use KVK API to checkout legal status of compay at login [#2808] Use KVK API to check legal status of compay at login Jan 10, 2025
@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch 2 times, most recently from d787ef9 to f003155 Compare January 10, 2025 15:58
@pi-sigma pi-sigma force-pushed the issue/2808-eherkenning-login-error-message branch from f003155 to 125b3b8 Compare January 10, 2025 16:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.12%. Comparing base (fbae2b8) to head (125b3b8).

Files with missing lines Patch % Lines
src/open_inwoner/accounts/views/auth.py 57.14% 6 Missing ⚠️
src/open_inwoner/kvk/client.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1544      +/-   ##
===========================================
- Coverage    94.13%   94.12%   -0.02%     
===========================================
  Files         1064     1064              
  Lines        39302    39343      +41     
===========================================
+ Hits         36997    37031      +34     
- Misses        2305     2312       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants