Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#2289] Add newsletter section checkbox styles #1155

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Apr 15, 2024

Task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2289
➕ also corrected some odd mistakes in other code here and there.

@jiromaykin jiromaykin marked this pull request as ready for review April 15, 2024 12:32
@jiromaykin jiromaykin marked this pull request as draft April 15, 2024 12:45
@jiromaykin jiromaykin force-pushed the feature/2289-profile-newsletter-styles branch from eebf1f0 to bfa0de7 Compare April 15, 2024 13:38
@jiromaykin jiromaykin changed the title 💄 [#2289] Adjusted newsletter section checkbox styles 💄 [#2289] Add newsletter section checkbox styles Apr 15, 2024
@stevenbal stevenbal force-pushed the feature/2289-profile-newsletter-styles branch from a1c8ef9 to 99667eb Compare April 15, 2024 14:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (32328ac) to head (92fc0e5).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1155      +/-   ##
===========================================
- Coverage    95.10%   95.05%   -0.06%     
===========================================
  Files          950      950              
  Lines        33775    33796      +21     
===========================================
+ Hits         32122    32124       +2     
- Misses        1653     1672      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin marked this pull request as ready for review April 15, 2024 15:48
@alextreme alextreme requested review from pi-sigma and stevenbal April 16, 2024 09:38
@jiromaykin jiromaykin force-pushed the feature/2289-profile-newsletter-styles branch from 46aee09 to 92fc0e5 Compare April 18, 2024 08:01
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partly reviewing my own code here, so @pi-sigma will have to look at the Python changes 😛

The rest looks good though 👍

@alextreme alextreme merged commit cfdcf0e into develop Apr 18, 2024
15 checks passed
@alextreme alextreme deleted the feature/2289-profile-newsletter-styles branch April 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants