[#2274] Pass data in Haalcenntraal POST as JSON #1145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1145 +/- ##
========================================
Coverage 95.07% 95.07%
========================================
Files 948 949 +1
Lines 33556 33574 +18
========================================
+ Hits 31903 31921 +18
Misses 1653 1653 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
fix/2274-haalcentraal-api
branch
from
1562055 to
dc4d178
Compare
pi-sigma
force-pushed
the
fix/2274-haalcentraal-api
branch
from
dc4d178 to
4c25c7d
Compare
| "burgerservicenummer": ["999993847"], | ||
| } | ||
|
|
||
| self.assertEqual(response.request.body, json.dumps(data).encode("utf-8")) |
There was a problem hiding this comment.
While this works for now I'd like to note I would've gone the other way: JSON parse the request body and compare it to the expected dict.
JSON serialization is technically not 100% stable (there are multiple valid JSON strings possible for the same data, because of dict ordering and pretty pretting), and in the assertion you'd get a structural diff instead of a text diff.
pi-sigma
force-pushed
the
fix/2274-haalcentraal-api
branch
from
4c25c7d to
1bbba84
Compare
| "burgerservicenummer": ["999993847"], | ||
| } | ||
|
|
||
| self.assertEqual(json.loads(response.request.body), data) |
There was a problem hiding this comment.
this could have used response.json, but I'll approve to get this merged for the release
Taiga: #2274