Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2207] Avoid showing the current status of the case twice in the situation where the zaak.status URL isn't in the status history #1139

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

alextreme
Copy link
Member

@alextreme alextreme requested review from stevenbal and pi-sigma April 5, 2024 09:43
@pi-sigma
Copy link
Contributor

pi-sigma commented Apr 5, 2024

@alextreme I'll look into the failing test. Apparently we have a conflict between showing too much and too little with the E-suite's behavior in this case. Do you happen to have a reference to where this (status duplicated) happened?

@alextreme
Copy link
Member Author

@pi-sigma from my analysis (see the Taiga issue) the duplication occurs regardless of zaaktype when our eSuite-workaround is necessary

@alextreme
Copy link
Member Author

By the way, Andy is checking if he can fix in the eSuite that this workaround is no longer necessary

@pi-sigma
Copy link
Contributor

pi-sigma commented Apr 5, 2024

That would be nice!

@pi-sigma
Copy link
Contributor

pi-sigma commented Apr 5, 2024

Not sure what can be done about the failing test. If fetch_status_history returns an empty list, it still seems necessary to add the status to statuses (not just the mapping). I haven't seen the strange behavior with the UUIDs Steven reports in the Taiga discussion.

However, the second test concerning missing statuses and the hidden upload button (link) is broken; it passes independently of whether fetch_status_history returns an empty list or not. Should be marked with @skip() and reviewed (or deleted).

@alextreme
Copy link
Member Author

Discuss the failing tests at the office next week with Steven or Bart. If fetch_status_history returns an empty list then having statuses be the empty list makes sense, this seems to be different than the situation we see so imho this test is to be rewritten or if it's no longer applicable removed.

…uation where the zaak.status URL isn't in the status history
@stevenbal stevenbal force-pushed the issue/2207-avoid-duplicate-statusses branch from c8ff97b to 013e1e2 Compare April 11, 2024 13:28
@patch(
"open_inwoner.openzaak.clients.ZakenClient.fetch_status_history", autospec=True
)
def test_e_suite_missing_current_status_fetch_status(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alextreme I'm now unsure what is still and issue and what is not, but from what I understood from the taiga issue, this regression test is no longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it can be removed

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (f36f589) to head (013e1e2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1139      +/-   ##
===========================================
- Coverage    95.07%   95.07%   -0.01%     
===========================================
  Files          948      948              
  Lines        33556    33544      -12     
===========================================
- Hits         31903    31891      -12     
  Misses        1653     1653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_e_suite_missing_current_status_upload_button_displayed should probably also be removed

def test_e_suite_missing_current_status_upload_button_displayed(

@stevenbal stevenbal force-pushed the issue/2207-avoid-duplicate-statusses branch from 013e1e2 to 09bdc1a Compare April 12, 2024 14:08
@stevenbal stevenbal requested a review from pi-sigma April 12, 2024 14:08
@alextreme alextreme merged commit f91a428 into develop Apr 12, 2024
15 checks passed
@alextreme alextreme deleted the issue/2207-avoid-duplicate-statusses branch April 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants