💄 [#2272] Position indicator dot headings #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
fix/2272-heading-dot-filelist
branch
from
a9977c5 to
631ea4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1134 +/- ##
========================================
Coverage 95.05% 95.05%
========================================
Files 950 950
Lines 33790 33790
========================================
Hits 32119 32119
Misses 1671 1671 ☔ View full report in Codecov by Sentry. |
jiromaykin
force-pushed
the
fix/2272-heading-dot-filelist
branch
5 times, most recently
from
3e1a988 to
a22cc27
Compare
jiromaykin
force-pushed
the
fix/2272-heading-dot-filelist
branch
from
39546f3 to
06a0c9f
Compare
stevenbal
approved these changes
Apr 18, 2024
| @@ -31,8 +31,18 @@ | |||
| &__data { | |||
| display: flex; | |||
| flex-direction: column; | |||
| adding: var(--spacing-large); | |||
There was a problem hiding this comment.
Typo probably? I see padding below, so I think this can be removed
There was a problem hiding this comment.
Oops... this should not be approved :-D since there is another padding statement a couple of lines lower. I'll fix this.
There were multiple statements for this very same class in multiple places so I wanted to group them all together here.
There was a problem hiding this comment.
I have fixed this :-D
pi-sigma
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2272
The nature of 'shrinking' a breaking text where the wrap-width is unknown turned out quite difficult; therefor I am using a rather unique grid in order to make the indicator appear as close to the breaking text as possible with media-queries.
In this PR I am also fixing the ellipsis for long file-names
➕ minor improvements of the case-detail page.
To test dot for file-list, increase default value of
DOCUMENT_RECENT_DAYS = config("DOCUMENT_RECENT_DAYS", default=1)