-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vragen detail conform to design #1112
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1112 +/- ##
===========================================
- Coverage 95.10% 95.05% -0.06%
===========================================
Files 950 950
Lines 33775 33790 +15
===========================================
- Hits 32122 32119 -3
- Misses 1653 1671 +18 ☔ View full report in Codecov by Sentry. |
src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss
Outdated
Show resolved
Hide resolved
3be2e5a
to
abbddc4
Compare
src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss
Outdated
Show resolved
Hide resolved
src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss
Outdated
Show resolved
Hide resolved
95a03fb
to
cbecc7b
Compare
src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss
Outdated
Show resolved
Hide resolved
ceaeb5d
to
3764236
Compare
8e8a09f
to
c3f4b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can't see the proper values in Figma, look at the design in Dev mode
. If you are unable to measure the distance between elements in Figma, you can toggle Dev mode off and CTRL-select an element and use the ALT key to see the distance to another element (by hovering).
These are the proper margins in Figma (although they may look a bit too big in a browser 🤔):
![figma-proper-devmode](https://private-user-images.githubusercontent.com/118177951/319717569-392295dd-8b1c-451a-ac9b-e64e5e18c3f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTIxMjAsIm5iZiI6MTczOTE5MTgyMCwicGF0aCI6Ii8xMTgxNzc5NTEvMzE5NzE3NTY5LTM5MjI5NWRkLThiMWMtNDUxYS1hYzliLWU2NGU1ZTE4YzNmNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQxMjUwMjBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMDAxMTJiMjU5NzhlMDY2YWEwNmVmMTBhOTJkMDgyYWEyMDM0MjhjMDlkZjViMzA3MjlmYjk1YjVmMzAyOWFkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.iBFN3GmamtvFubgUIsmCqqgGDj0-TngudJZoVdFrqJU)
src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss
Outdated
Show resolved
Hide resolved
2c204e1
to
209859c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two navigation buttons at the bottom look a bit strange but that is because they will contain less text than they do in the design, so that's okay for now.
Also: this branch will need rebasing.
209859c
to
6052879
Compare
Design: Figma