Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vragen detail conform to design #1112

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

pi-sigma
Copy link
Contributor

Design: Figma

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (32328ac) to head (6052879).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/accounts/views/contactmoments.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1112      +/-   ##
===========================================
- Coverage    95.10%   95.05%   -0.06%     
===========================================
  Files          950      950              
  Lines        33775    33790      +15     
===========================================
- Hits         32122    32119       -3     
- Misses        1653     1671      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review March 25, 2024 10:15
@pi-sigma pi-sigma requested a review from jiromaykin March 25, 2024 10:15
src/open_inwoner/accounts/views/contactmoments.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/views/contactmoments.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/tests/test_views.py Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/contactmoment/detail.html Outdated Show resolved Hide resolved
src/open_inwoner/openklant/tests/test_views.py Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/contactmoment/detail.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/contactmoment/detail.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/contactmoment/detail.html Outdated Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the fix/mijn-vragen-detail branch 2 times, most recently from 95a03fb to cbecc7b Compare March 27, 2024 09:36
@pi-sigma pi-sigma requested a review from jiromaykin March 27, 2024 11:15
@pi-sigma pi-sigma force-pushed the fix/mijn-vragen-detail branch 4 times, most recently from ceaeb5d to 3764236 Compare April 2, 2024 09:03
@pi-sigma pi-sigma requested a review from jiromaykin April 2, 2024 13:26
@pi-sigma pi-sigma force-pushed the fix/mijn-vragen-detail branch 2 times, most recently from 8e8a09f to c3f4b34 Compare April 2, 2024 15:19
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can't see the proper values in Figma, look at the design in Dev mode. If you are unable to measure the distance between elements in Figma, you can toggle Dev mode off and CTRL-select an element and use the ALT key to see the distance to another element (by hovering).

These are the proper margins in Figma (although they may look a bit too big in a browser 🤔):

figma-proper-devmode

@pi-sigma pi-sigma force-pushed the fix/mijn-vragen-detail branch 2 times, most recently from 2c204e1 to 209859c Compare April 8, 2024 14:12
@pi-sigma pi-sigma requested a review from jiromaykin April 12, 2024 07:18
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two navigation buttons at the bottom look a bit strange but that is because they will contain less text than they do in the design, so that's okay for now.
Also: this branch will need rebasing.

@pi-sigma pi-sigma force-pushed the fix/mijn-vragen-detail branch from 209859c to 6052879 Compare April 15, 2024 14:38
@alextreme alextreme merged commit a47782f into develop Apr 15, 2024
15 checks passed
@alextreme alextreme deleted the fix/mijn-vragen-detail branch April 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants