[#2106, #2203] Implemented 'contactform_confirmation' email #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
force-pushed
the
feature/2106-contact-confirmation-email
branch
from
c283508 to
3244e41
Compare
Bartvaderkin
changed the title
stevenbal
approved these changes
Mar 25, 2024
pi-sigma
approved these changes
Mar 25, 2024
alextreme
requested changes
Apr 2, 2024
src/open_inwoner/openklant/migrations/0011_openklantconfig_api_sends_email_confirmation.py
Outdated
Show resolved
Hide resolved
added 2 commits
April 18, 2024 09:49
…tConfig.api_sends_email_confirmation
Bartvaderkin
force-pushed
the
feature/2106-contact-confirmation-email
branch
from
3244e41 to
0143e9d
Compare
Bartvaderkin
force-pushed
the
feature/2106-contact-confirmation-email
branch
from
0143e9d to
07e9dbd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1106 +/- ##
===========================================
+ Coverage 95.05% 95.07% +0.01%
===========================================
Files 950 953 +3
Lines 33790 33920 +130
===========================================
+ Hits 32119 32249 +130
Misses 1671 1671 ☔ View full report in Codecov by Sentry. |
alextreme
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration code is pretty spicy. I tried refactoring but it does need many conditionals so except some small changes I kept it this way.