Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor resync tasks #627

Merged
merged 1 commit into from
Jan 27, 2025
Merged

♻️ Refactor resync tasks #627

merged 1 commit into from
Jan 27, 2025

Conversation

SilviaAmAm
Copy link
Collaborator

No description provided.

@SilviaAmAm SilviaAmAm marked this pull request as draft January 21, 2025 11:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (20ed740) to head (a528b84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   88.32%   88.29%   -0.03%     
==========================================
  Files         210      210              
  Lines        6074     6059      -15     
  Branches      639      639              
==========================================
- Hits         5365     5350      -15     
  Misses        709      709              
Flag Coverage Δ
backend 91.41% <100.00%> (-0.04%) ⬇️
jest 32.81% <ø> (ø)
storybook 79.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the refactor/resync_tasks branch from 519f6c9 to a528b84 Compare January 27, 2025 10:18
@SilviaAmAm SilviaAmAm marked this pull request as ready for review January 27, 2025 10:18
with zrc_client:
with transaction.atomic(), zrc_client, selectielijst_api_client or NoClient():
if is_full_resync:
Zaak.objects.all().delete()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to delete destruction list items as well?

Copy link
Collaborator Author

@SilviaAmAm SilviaAmAm Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! The items have a _zaak_url field which will be used to re-link them to the new zaak if it exists. They only need to be deleted if no the zaak to which they were linked to is no longer present. This check happens in resync_items_and_zaken()

@SilviaAmAm SilviaAmAm merged commit f606c01 into main Jan 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants