♻️ Refactor resync tasks #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 88.32% 88.29% -0.03%
==========================================
Files 210 210
Lines 6074 6059 -15
Branches 639 639
==========================================
- Hits 5365 5350 -15
Misses 709 709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SilviaAmAm
force-pushed
the
refactor/resync_tasks
branch
from
519f6c9 to
a528b84
Compare
| with zrc_client: | ||
| with transaction.atomic(), zrc_client, selectielijst_api_client or NoClient(): | ||
| if is_full_resync: | ||
| Zaak.objects.all().delete() |
There was a problem hiding this comment.
Do we need to delete destruction list items as well?
There was a problem hiding this comment.
No! The items have a _zaak_url field which will be used to re-link them to the new zaak if it exists. They only need to be deleted if no the zaak to which they were linked to is no longer present. This check happens in resync_items_and_zaken()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.