Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#558] Refactor queue destruction endpoint #564

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

Partially fixed #558

I think that it makes more sense to have this endpoint be a POST, and then the endpoint that actually deletes the destruction list resource be a DELETE

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (4e0eaff) to head (802feed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   84.18%   84.17%   -0.01%     
==========================================
  Files         208      208              
  Lines        5639     5642       +3     
  Branches      570      570              
==========================================
+ Hits         4747     4749       +2     
- Misses        892      893       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I expect the frontend function names to reflect the backend ones more closely.

frontend/src/lib/api/destructionLists.ts Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm force-pushed the feature/558-endpoint-to-delete-list branch from 35ce788 to 802feed Compare December 20, 2024 13:44
@SilviaAmAm SilviaAmAm merged commit 1fe1f25 into main Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lijst in status nieuw annuleren
3 participants