Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#502] Add review process to destruction report #526

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

Fixes #502

Based on #525

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (07cfcab) to head (24c8c2f).

Files with missing lines Patch % Lines
backend/src/openarchiefbeheer/accounts/utils.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   79.94%   80.03%   +0.09%     
==========================================
  Files         201      202       +1     
  Lines        5490     5526      +36     
  Branches      550      550              
==========================================
+ Hits         4389     4423      +34     
- Misses       1101     1103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenvandescheur
Copy link
Contributor

Maybe target this PR to #525 so we can easily see the diff?

@SilviaAmAm SilviaAmAm changed the base branch from main to feature/502-make-report-xlsx December 3, 2024 09:14
backend/src/openarchiefbeheer/destruction/models.py Outdated Show resolved Hide resolved
backend/src/openarchiefbeheer/destruction/models.py Outdated Show resolved Hide resolved
backend/src/openarchiefbeheer/destruction/models.py Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm force-pushed the feature/502-make-report-xlsx branch from 9daedd7 to 4c2b867 Compare December 3, 2024 14:37
@SilviaAmAm SilviaAmAm changed the base branch from feature/502-make-report-xlsx to main December 3, 2024 15:13
@SilviaAmAm SilviaAmAm force-pushed the feature/502-review-process-report branch from 78b1038 to 24c8c2f Compare December 3, 2024 16:35
@SilviaAmAm SilviaAmAm merged commit 0c2da26 into main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Historie van vernietigingsproces bij vernietigde metadata
3 participants