Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#317] Prevent saving duplicates #333

Closed
wants to merge 3 commits into from
Closed

[#317] Prevent saving duplicates #333

wants to merge 3 commits into from

Conversation

ErhanCitil
Copy link
Contributor

Fixes #317

@ErhanCitil ErhanCitil requested a review from annashamray May 19, 2023 10:29
@ErhanCitil ErhanCitil self-assigned this May 19, 2023
@ErhanCitil ErhanCitil linked an issue May 19, 2023 that may be closed by this pull request
As admin in the objects admin, I want to prevent saving duplicates while adding objecttypes to the objecttypes-api. #317
Open
@alextreme
Copy link
Member

To be discussed with Anna. Problem is that in the objecttypes ( https://github.com/maykinmedia/objecttypes-api/blob/master/src/objecttypes/core/models.py ) ObjectType.name also isn't unique.

Further more, I suspect that the Objects API supports multiple ObjectType instances (multiple services). So I'm not sure if we can do this by adding unique=True on the _name field.

@ErhanCitil ErhanCitil requested a review from alextreme June 29, 2023 15:19
@annashamray annashamray removed their request for review May 10, 2024 13:27
@alextreme alextreme closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme Awaiting requested review from alextreme

Assignees

@ErhanCitil ErhanCitil

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ErhanCitil @alextreme