Improve linting/tidying config

[oschwald]

• Add mise configuration for tooling
• Migrate precious workflow to use mise
• Add golangci-lint to precious config

[gemini-code-assist]

Summary of Changes

Hello @oschwald, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's development environment by enhancing its linting and tidying configurations. It introduces 'mise' for streamlined tool management, ensuring that essential development tools are consistently provisioned. Furthermore, it integrates 'golangci-lint' into the 'precious' workflow, providing automated formatting and linting capabilities for Go source code.

Highlights

• Tooling Management with Mise: Introduced 'mise' (formerly 'rtx') to manage development tools like Go, Node, 'golangci-lint', 'precious', and 'prettier', ensuring consistent versions across the project.
• Precious Workflow Integration: The 'precious' configuration was updated to leverage 'mise' for executing 'prettier', simplifying the command by removing the 'npx' prefix.
• Go Linting and Formatting: Integrated 'golangci-lint' into the 'precious' workflow, adding commands for both 'fmt' (formatting with '--diff') and 'run' (linting with '--fix') for Go files.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/golangci-lint.yml
  • .github/workflows/precious.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the project's linting and tidying setup by introducing mise for tool version management and adding golangci-lint to the precious configuration. The changes are a good step towards standardizing the development environment.

My review focuses on the new mise.toml file. I've recommended pinning tool versions instead of using latest to ensure reproducible builds. This is a high-priority suggestion to prevent unexpected breakages in the future. The rest of the changes look good.

[gemini-code-assist]

Using latest for tool versions can lead to non-reproducible builds. If a new version of a tool is released with breaking changes, it could break the development environment or CI/CD pipeline unexpectedly. It's a best practice to pin tools to specific versions to ensure everyone is using the same toolchain and that builds are deterministic.

You should replace latest with specific versions. For example:

go = "1.22.0"
node = "20.11.0"
golangci-lint = "1.56.2"
"github:houseabsolute/precious" = "0.4.0"
"npm:prettier" = "3.2.5"

Please choose the versions that are appropriate for your project.

Suggested change

	go = "latest"
	node = "latest"
	golangci-lint = "latest"
	"github:houseabsolute/precious" = "latest"
	"npm:prettier" = "latest"
	go = "1.22.0"
	node = "20.11.0"
	golangci-lint = "1.56.2"
	"github:houseabsolute/precious" = "0.4.0"
	"npm:prettier" = "3.2.5"

[oschwald]

I agree with this, but we previously used the latest versions and we would need to come up with a plan to keep them up to date.