Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use custom dialect with pymavlink installed pip #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emialonzo
Copy link

Add instructions to use custom dialect python file in code running pymavlink installed with pip

emialonzo and others added 2 commits June 17, 2020 13:03
Add instructions to use custom dialect python file in code running pymavlink installed with pip
@hamishwillee
Copy link
Collaborator

Thanks @emialonzo
So basically you're installing the files locally, updating the CRC and importing your own library?

Why would you choose to do it this way rather than recreate the library for your dialect? The reason I ask is that it is good to give users a clear path to take. If this is "just another way" I'd rather not include it. If it is another way with significant advantages then yes, we should include it.

@emialonzo
Copy link
Author

HI @hamishwillee
I think this method is better because it makes it easier to distribute the code. You can use pip to install pymavlink and then include a single .py file with the definition of the new dialect without being coupled to the pymavlink or mavlink (mavgen) source code.
Regarding the CRC, I only update the path to the CRC module to use the one installed by pip and not the one associated to the mavgen source code.

@hamishwillee
Copy link
Collaborator

@emialonzo Thanks. I am not ignoring you, just got swamped by other work. Hope to look at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants