Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMAKE_INSTALL_PREFIX #2482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CMAKE_INSTALL_PREFIX #2482

wants to merge 1 commit into from

Conversation

battlesnake
Copy link

@battlesnake battlesnake commented Dec 19, 2024 •
edited
Loading

forked + PR to test #2475

@battlesnake
Copy link
Author

CI workflow needs approval to trigger

@JonasVautherin
Copy link
Collaborator

What happens if you don't set CMAKE_INSTALL_PREFIX at all and let the default value be used? Feels weird to manually set /usr 🤔

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@julianoes
Copy link
Collaborator

@JonasVautherin it has to be /usr otherwise it's /usr/local and would be wrong again.

You will have to add sudo to the install step though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battlesnake @JonasVautherin @julianoes