Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param_server: allow to change parameter internally #317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dayjaby
Copy link
Contributor

@dayjaby dayjaby commented Jun 11, 2023

Allow a param_server to change a parameter that it is providing.

@dayjaby dayjaby force-pushed the parameter_server_local_change branch from 279889c to 8a62fff Compare June 11, 2023 21:46
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we (couldn't we?) do that by calling ProvideParam again with the same name but a different value?

@julianoes
Copy link
Collaborator

I think this makes sense. The tricky thing is that you're supposed to "provide" all params on init, before any mavlink traffic happens, and the number of params can't change later.

@JonasVautherin
Copy link
Collaborator

The tricky thing is that you're supposed to "provide" all params on init, before any mavlink traffic happens

Oh so that can't work with the language bindings, right?

@dayjaby
Copy link
Contributor Author

dayjaby commented Jun 12, 2023

Language bindings should be fine. So a python mavsdk app for example can represent an entire mavlink component, using the param_server plugin to provide all the parameters. If something happens within the component, the same plugin should be able to be used to "change" one of these parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants