Add cellular_status and cellular_modem_info #309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
requested changes
Jan 23, 2023
protos/telemetry/telemetry.proto
Outdated
| @@ -640,6 +658,26 @@ message RcStatus { | |||
| float signal_strength_percent = 3 [(mavsdk.options.default_value)="NaN"]; // Signal strength (range: 0 to 100, NaN if unknown) | |||
| } | |||
|
|
|||
| // Cellular modem status type. | |||
| message CellularStatus { | |||
| uint32 id = 1;// (actually uint8_t) | |||
There was a problem hiding this comment.
I'd say there is no need to specify "actually uint8_t". The MAVSDK API does not have to explain the MAVLink implementation details. However, it would be nice to describe what those fields are, because this will be part of the generated documentation :-)
potaito
force-pushed
the
cellular_status
branch
from
16b5579
to
5be6911
Compare
potaito
reviewed
Feb 3, 2023
| @@ -294,6 +314,39 @@ message RcStatus { | |||
| float signal_strength_percent = 3 [(mavsdk.options.default_value)="NaN"]; // Signal strength (range: 0 to 100, NaN if unknown) | |||
| } | |||
|
|
|||
| // Cellular modem status type. | |||
| message CellularStatus { | |||
| uint32 status = 1; | |||
There was a problem hiding this comment.
By the way, this is how I added status flags for the winch as a separate proto message: https://github.com/mavlink/MAVSDK-Proto/pull/308/files#diff-c29712674081664a7c33c32b2a4772848836bbbe76c1f1de17d5cb82b9f512acR73-R88
I.e. all bit flags from MAVLink became Booleans in Proto.
asimopunov
changed the title
|
There hasn't been activity here in a while. Are you still planning to complete this @akkawimo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs