generated from readthedocs/tutorial-template
-
Notifications
You must be signed in to change notification settings - Fork 67
Cherry-pick: "Added Tip to Variables for using Custom Company Fields" to 5.x #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adiati98
wants to merge
7
commits into
mautic:5.x
Choose a base branch
from
adiati98:cherry-pick-310-b5x
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation lacks a hint, that the syntax for using core company fields as tokens and custom created onces is different. I added a small "ProTip" to briefly explain this difference.
adiati98
commented
Jan 28, 2026
adiati98
commented
Jan 28, 2026
adiati98
commented
Jan 28, 2026
|
|
||
| **Custom Company fields** | ||
|
|
||
| The syntax for custom Company fields differs from core Company field syntax. You must **not** add the word "Company" in the variable and instead treat it as a ``contactfield``. |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RCheesley I'm trying to keep the original version (with slight wording changes). But do you think the below is clearer and hold the same meaning? If so, I'll fix this and other PRs for other branches.
Suggested change
| The syntax for custom Company fields differs from core Company field syntax. You must **not** add the word "Company" in the variable and instead treat it as a ``contactfield``. | |
| Unlike core Company fields, custom Company fields require the ``contactfield`` syntax. Don't include the word 'Company' in the variable name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks #310 into the 5.x branch as it's made directly on the 5.x branch and we can't co-author the PR.
This PR also addresses the build fails by fixing the external links and renames some files following the existing branches for consistency.
Linked issue
Screenshots or screen recordings