Refactor PHP extension install procedure and remove build dependencies #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@J0WI despite the proposed improvements, the mautic 2 image works well. What do you think of using all this refactoring in the Mautic 3 image? |
|
@J0WI can we talk on Mautic's Slack? i'm luizeof there. |
This PR does not contain any breaking change, but #157 does. There is currently no branch for Mautic 3 otherwise I would create a PR against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #157. Nothing changes in the final result, but the image is slightly smaller.
Note, mbstring is already installed by default
cc @luizeof