Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-compose.yml #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sriram18981
Copy link

Added docker-compose file to start the server quickly.

@sriram18981
Copy link
Author

Adding a basic docker-compose file will reduce the conflicts on the documentation, and users will be able to quickly start and experiment on the server.

Copy link
Contributor

@aspiers aspiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo already has a docker-compose.yml. If this is not obvious enough then the docs should be improved rather than adding another one.

@sriram18981
Copy link
Author

Yes, it already has a docker-compose file. But, that is for usage with nginx and SSL. If any one just want to install and play, why should they be having nginx and SSL?

@sriram18981
Copy link
Author

sriram18981 commented Jul 18, 2019

Besides, running the docker-compose in my Mac is showing below error.

Sriram$ docker-compose up -d
Creating mautic_mysql_1 ... done
Creating mautic_mautic_1 ... done
Creating mautic_nginx_1  ... error

ERROR: for mautic_nginx_1  Cannot start service nginx: b'OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \\"rootfs_linux.go:58: mounting \\\\\\"/Users/Sriram/git/mautic/nginx.conf\\\\\\" to rootfs \\\\\\"/var/lib/docker/overlay2/580aa30e53860f79314eb80c3ba25af3200166c7d101d8668b682174789ee808/merged\\\\\\" at \\\\\\"/var/lib/docker/overlay2/580aa30e53860f79314eb80c3ba25af3200166c7d101d8668b682174789ee808/merged/etc/nginx/conf.d/default.conf\\\\\\" caused \\\\\\"not a directory\\\\\\"\\"": unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type'

ERROR: for nginx  Cannot start service nginx: b'OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \\"rootfs_linux.go:58: mounting \\\\\\"/Users/Sriram/git/mautic/nginx.conf\\\\\\" to rootfs \\\\\\"/var/lib/docker/overlay2/580aa30e53860f79314eb80c3ba25af3200166c7d101d8668b682174789ee808/merged\\\\\\" at \\\\\\"/var/lib/docker/overlay2/580aa30e53860f79314eb80c3ba25af3200166c7d101d8668b682174789ee808/merged/etc/nginx/conf.d/default.conf\\\\\\" caused \\\\\\"not a directory\\\\\\"\\"": unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type'
ERROR: Encountered errors while bringing up the project.

@luizeof
Copy link
Member

luizeof commented Jul 19, 2019

The "links" option is deprecated ... as see https://docs.docker.com/compose/compose-file/#links

@sriram18981
Copy link
Author

The "links" option is deprecated ... as see https://docs.docker.com/compose/compose-file/#links

@luizeof - Thanks for the comment. Updated the compose file accordingly.

@sriram18981
Copy link
Author

@luizeof or @aspiers Can you please review?

@aspiers
Copy link
Contributor

aspiers commented Aug 27, 2019

If any one just want to install and play, why should they be having nginx and SSL?

Several reasons:

  • The whole point of docker-compose is to make deploying a multi-component architecture as easy as deploying a single-component one.
  • The more alternatives we offer users for deployment, the less each path will be trodden. This fragmentation of the community is harmful: as a result each deployment technique will be less tested, resulting in more problems, more duplication of effort fixing them, worse documentation, etc.
  • One quick example of the above is Chrome shows Mautic dashboard as not fully secure mautic#7577. Trying to support both SSL and non-SSL effectively doubles the test matrix both for CI and manual testing.

So I'm sorry to disagree, but I don't see how adding another docker-compose.yml file will "reduce the conflicts on the documentation"; I expect it would achieve the opposite effect. If there are issues with the existing file then let's fix those rather than adding a largely overlapping alternative which might introduce a new set of challenges.

That's just my opinion though. @luizeof, @RCheesley - would be good to get your takes on this.

@luizeof
Copy link
Member

luizeof commented Oct 15, 2019

Hello @sriram18981 , how are you? sorry for the delay. Due to the moves between Mautic / Aquia there was some delay in communication between the mautic team and me about the permissions on the dockerhub and github repository.

Now the problem is solved and I will come back with the pulls and issues.

Could you please update your pull with the latest version of the master? just to avoid merge problems.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants