Add feature to disable auto attach target #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a `enable_stealth_mode` function on the `Page` struct based on `headless_chrome`'s implementation to make it harder for websites to block users of this crate
This will fix #163, I'm adding this as an opt-in feature because I'm not sure if it has other side effects
|
Idk why this pull request included the stealth mode commit again, I must've done something wrong when I made that PR, but you can check the commits to see the code hasn't been changed at all |
|
Also, I just realized this should be named |
escritorio-gustavo
changed the title
Note: there is still one clippy warning on `chromiumoxide_fetcher\src\browser`, but it's about the name of a `pub` method, so changing it would be a breaking change, which I didn't want to cause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is closed in favor of #174