Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close statement when missing query arguments #1281

Merged
merged 1 commit into from
Oct 4, 2024
Merged

close statement when missing query arguments #1281

merged 1 commit into from
Oct 4, 2024

Conversation

mattn
Copy link
Owner

@mattn mattn commented Oct 4, 2024

fixes #1280

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.13%. Comparing base (18cdded) to head (6cc847b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sqlite3.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1281      +/-   ##
==========================================
- Coverage   47.16%   47.13%   -0.04%     
==========================================
  Files          12       12              
  Lines        1533     1534       +1     
==========================================
  Hits          723      723              
- Misses        669      670       +1     
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattn mattn merged commit 82bc911 into master Oct 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql.DB.Close does not close the DB after a query error
2 participants