Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a user-friendly message to display when user authenticates but email does not match #170

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

Nityanand13
Copy link
Contributor

@Nityanand13 Nityanand13 commented Feb 15, 2023

Summary

Created a user-friendly message to display when user authenticates but email does not match.

Ticket Link

Fixes #139

…nticates but email does not match (#43)

* [MI-2706]: Created a user-friendly message to display when user authenticates but email does not match

* [MI-2706]: Solved linting errors
@hanzei hanzei added the Work In Progress Not yet ready for review label Mar 28, 2023
@ayusht2810 ayusht2810 requested review from mickmister and hanzei May 31, 2023 12:28
@ayusht2810 ayusht2810 self-assigned this May 31, 2023
@ayusht2810
Copy link
Contributor

@hanzei @mickmister fixed the issue. Please review

@hanzei hanzei added 2: Dev Review Requires review by a core committer and removed Work In Progress Not yet ready for review labels May 31, 2023
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label May 31, 2023
@hanzei hanzei removed request for mickmister and hanzei May 31, 2023 15:24
@hanzei
Copy link
Contributor

hanzei commented May 31, 2023

@Nityanand13 Let me check who is the correct reviewer for this repository.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 8, 2023
@hanzei hanzei enabled auto-merge (squash) August 8, 2023 10:39
@hanzei
Copy link
Contributor

hanzei commented Oct 11, 2023

@Nityanand13 Please merge master into your PR

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bd58e0b) 66.79% compared to head (f2b35a6) 66.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files          16       16           
  Lines        2027     2027           
=======================================
  Hits         1354     1354           
  Misses        633      633           
  Partials       40       40           
Files Coverage Δ
server/plugin/client.go 76.11% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Oct 16, 2023
@fmartingr fmartingr changed the title Fixed issue #139 Created a user-friendly message to display when user authenticates but email does not match Mar 15, 2024
@hanzei hanzei merged commit a9348dd into mattermost:master Apr 2, 2024
4 checks passed
@hanzei hanzei removed the Awaiting Submitter Action Blocked on the author label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a user-friendly page to display when user authenticates but email does not match
7 participants