Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-6831 Fix autolink dependency path #1135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wiggin77
Copy link
Member

@wiggin77 wiggin77 commented Nov 5, 2024

Summary

When the autolink plugin was moved from mattermost org to mattermost-community the module path was not updated for this Jira plugin. This PR resolves it.

This issue was discovered via automated scan.

Ticket Link

https://mattermost.atlassian.net/browse/SEC-6831

@wiggin77 wiggin77 added the 3: QA Review Requires review by a QA tester label Nov 5, 2024
@wiggin77
Copy link
Member Author

wiggin77 commented Nov 5, 2024

@AayushChaudhary0001 this changes the version of autolink used in the Jira plugin. We'll need a test to make sure link resolution still works. This can be tested for next release, or tested before merge at your discretion.

@wiggin77
Copy link
Member Author

wiggin77 commented Nov 5, 2024

@raghavaggarwal2308 we have a bunch of PRs failing CI CodeQL step. Can you look into this and unblock the PRs?

@raghavaggarwal2308
Copy link
Contributor

@wiggin77 Sure, we are looking into it

@AayushChaudhary0001
Copy link

This PR has been tested for Jira plugin, and it was found not working. On pasting the link of any desired ticket from Jira, it was presented to the user as original link and not the ticket ID as a link.

@raghavaggarwal2308
Copy link
Contributor

raghavaggarwal2308 commented Nov 11, 2024

@wiggin77

  • We looked into the above issue and found out the code implemented for setting up autolinks is for Jira cloud instance (Using JWT token for auth) only and we moved to oauth2 recently.
  • To make this work we will have to update that logic to use cloudOauth instance.

Should we log an issue for the above and fix it?

@wiggin77
Copy link
Member Author

/update-branch

@wiggin77
Copy link
Member Author

wiggin77 commented Nov 12, 2024

Should we log an issue for the above and fix it?

Yes please @raghavaggarwal2308

@wiggin77
Copy link
Member Author

Should we log an issue for the above and fix it?

Yes please @raghavaggarwal2308

@raghavaggarwal2308 also can we get a unit test to detect this issue so it can be caught before manual testing?

@raghavaggarwal2308
Copy link
Contributor

@wiggin77 Sure, we will add the unit testcases

@raghavaggarwal2308
Copy link
Contributor

This PR should be merged after #1139

@wiggin77
Copy link
Member Author

@raghavaggarwal2308 what is the status on getting this SEC ticket merged?

@raghavaggarwal2308
Copy link
Contributor

@wiggin77 We will try to get the autolink PR QA reviewed and merged ASAP. After that we can get this PR QA tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants