-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEC-6831 Fix autolink dependency path #1135
base: master
Are you sure you want to change the base?
Conversation
@AayushChaudhary0001 this changes the version of autolink used in the Jira plugin. We'll need a test to make sure link resolution still works. This can be tested for next release, or tested before merge at your discretion. |
@raghavaggarwal2308 we have a bunch of PRs failing CI CodeQL step. Can you look into this and unblock the PRs? |
@wiggin77 Sure, we are looking into it |
This PR has been tested for Jira plugin, and it was found not working. On pasting the link of any desired ticket from Jira, it was presented to the user as original link and not the ticket ID as a link. |
Should we log an issue for the above and fix it? |
/update-branch |
Yes please @raghavaggarwal2308 |
@raghavaggarwal2308 also can we get a unit test to detect this issue so it can be caught before manual testing? |
@wiggin77 Sure, we will add the unit testcases |
This PR should be merged after #1139 |
@raghavaggarwal2308 what is the status on getting this SEC ticket merged? |
@wiggin77 We will try to get the autolink PR QA reviewed and merged ASAP. After that we can get this PR QA tested |
Summary
When the autolink plugin was moved from
mattermost
org tomattermost-community
the module path was not updated for this Jira plugin. This PR resolves it.This issue was discovered via automated scan.
Ticket Link
https://mattermost.atlassian.net/browse/SEC-6831