Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-62084] fix spacing between bookmarks, align + icon #8476

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MM-62084] fix spacing between bookmarks, align + icon #8476

wants to merge 1 commit into from

Conversation

Willyfrog
Copy link
Contributor

@Willyfrog Willyfrog commented Jan 14, 2025 •
edited by jira bot
Loading

Summary

Ticket Link

MM-62084

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on: ios emulator, Xiaomi Mi 8

Screenshots

CleanShot 2025-01-14 at 13 35 23@2x

Release Note

NONE

@Willyfrog Willyfrog added 2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer labels Jan 14, 2025
@Willyfrog Willyfrog self-assigned this Jan 14, 2025
asaadmahmood
asaadmahmood approved these changes Jan 14, 2025
View reviewed changes
Copy link

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asaadmahmood
Copy link

@Willyfrog can we also check what the tap looks like? If you can record a video and share that. I want to see the outline of that button when you tap.

@Willyfrog
Copy link
Contributor Author

@Willyfrog can we also check what the tap looks like? If you can record a video and share that. I want to see the outline of that button when you tap.

does this work?
CleanShot 2025-01-14 at 13 47 48

@Willyfrog Willyfrog removed the 2: UX Review Requires review by a UX Designer label Jan 14, 2025
@Willyfrog Willyfrog requested review from larkox and pvev January 14, 2025 15:05
pvev
pvev approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@pvev pvev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Willyfrog Willyfrog added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core commiter labels Jan 14, 2025
@Willyfrog Willyfrog requested a review from lindy65 January 14, 2025 15:56
@Willyfrog Willyfrog added the Build Apps for PR Build the mobile app for iOS and Android to test label Jan 14, 2025
lindy65
lindy65 approved these changes Jan 14, 2025
View reviewed changes
Copy link

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Willyfrog - looks good 👍

@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed Build Apps for PR Build the mobile app for iOS and Android to test 3: QA Review Requires review by a QA tester labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindy65 lindy65 lindy65 approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@pvev pvev pvev approved these changes

@larkox larkox larkox approved these changes

Assignees

@Willyfrog Willyfrog

Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Willyfrog @asaadmahmood @larkox @pvev @lindy65 @mm-cloud-bot