Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Mobile Drafts tests cases #8469

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open

E2E: Mobile Drafts tests cases #8469

wants to merge 100 commits into from

Conversation

yasserfaraazkhan
Copy link
Contributor 

NONE

@Rajat-Dabade
refactor: started with draft, done until new tabs for draft
63b313f
@Rajat-Dabade
refactor: change the query and added the screen for draft
11e758e
@Rajat-Dabade
added condition for fetching draft for channel delete or not
d72a19f
@Rajat-Dabade
refactor: added draft screen
572d65b
@Rajat-Dabade
linter fixes
d5389b8
@Rajat-Dabade
Added draft post component
ae55bde
@Rajat-Dabade
added avatar and header display name for the draft post list
afbe59d
@Rajat-Dabade
added channel info component
6c99a7c
@Rajat-Dabade
channel info completed
9fcbf84
@Rajat-Dabade
proper naming
d688908
@Rajat-Dabade
added image file markdown acknowledgement support
324aa16
@Rajat-Dabade
draft actions
65b6edd
@Rajat-Dabade
Fix the draft receiver in drafts
272c468
@Rajat-Dabade
separated send message handler
1fa189a
@Rajat-Dabade
Done with send drafts
ba3ee8d
@Rajat-Dabade
done with delete drafts
554123f
@Rajat-Dabade
change save to send draft
e629247
@Rajat-Dabade
handle lengthy message with show more button
f8bcead
@Rajat-Dabade
done with persistent message edit, send and delete drafts
6577c6e
@Rajat-Dabade
added alert for sending message
d331d46
@Rajat-Dabade
added update at time for the drafts
62d0bbb
@Rajat-Dabade
en.json extract fix
5308824
@Rajat-Dabade
Updated dependencies for useCallback
611cff0
@Rajat-Dabade
refactor: added drafts list to animated list
aac1f38
@Rajat-Dabade
added swipeable component and delete conformation for drafts
8c153d6
@Rajat-Dabade
done with rendering of images in markdown for drafts
112048a
@Rajat-Dabade
en.json issue fixed
2589127
@Rajat-Dabade
fix en.json issue
a70b165
@Rajat-Dabade
refactor: en.json fix
6f56a41
@Rajat-Dabade
addressed review comments
e140826
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Jan 10, 2025
@yasserfaraazkhan yasserfaraazkhan changed the base branch from mobile-drafts to main January 13, 2025 05:38
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 13, 2025
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 13, 2025
@yasserfaraazkhan yasserfaraazkhan changed the base branch from main to mobile-drafts January 13, 2025 10:39
@yasserfaraazkhan yasserfaraazkhan changed the title inti Init Jan 13, 2025
Base automatically changed from mobile-drafts to main January 13, 2025 13:10
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 14, 2025
@yasserfaraazkhan yasserfaraazkhan removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jan 14, 2025
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Jan 14, 2025
@yasserfaraazkhan yasserfaraazkhan changed the title Init E2E: Mobile Drafts tests cases Jan 14, 2025
@yasserfaraazkhan yasserfaraazkhan marked this pull request as ready for review January 14, 2025 15:02
Rajat-Dabade
Rajat-Dabade approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. LGTM 🚀

app/components/drafts_buttton/drafts_button.tsx Outdated Show resolved Hide resolved
larkox
larkox reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one thing to verify before approving.

app/screens/post_priority_picker/post_priority_picker.tsx
@@ -211,6 +212,7 @@ const PostPriorityPicker = ({
type='toggle'
selected={data.persistent_notifications}
descriptionNumberOfLines={2}
value='persistent_notifications'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking the implementation of how this value is used, and something feels really off. Can you verify if this doesn't break anything? The test I would do is:

  • Turn on persistent notifications
  • Turn them off again (verify they get visually turned off)
  • Create the post and verify the post was created without persistent notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox left review comments

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@saturninoabril saturninoabril Awaiting requested review from saturninoabril

Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasserfaraazkhan @larkox @Rajat-Dabade @mm-cloud-bot @mattermost-build