Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified private channel conversion requirements #7734

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cwarnermm
Copy link
Member

@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter 2. SME Review labels Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Newest code from mattermost has been published to preview environment for Git SHA cb2fc9a

Copy link
Contributor

@esarafianou esarafianou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was doing QA in the PR and checked our docs!

Comment on lines 56 to 60
Due to potential security concerns with sharing private channel history, only system admins can convert private channels to public channels.

.. note::

Team admins may be granted permissions to convert private channels to public channels via the `API <https://api.mattermost.com/#tag/channels/operation/UpdateChannelPrivacy>`_ or :ref:`mmctl channel modify command <manage/mmctl-command-line-tool:mmctl channel modify>` when configured in the :ref:`permission scheme <onboard/advanced-permissions:permissions structure>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwarnermm checking the implementation, this is not entirely the case.

Convertion from private to public can happen from team admins, sysadmins, and users with delegated granular administration roles with write access to User Management Channels and Groups. (PermissionSysconsoleWriteUserManagementChannels and PermissionSysconsoleWriteUserManagementGroups).

Teams admins are granted this permission by default but a system admin can configure to restrict this from team admins

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc. @JulienTant to verify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea you are correct @esarafianou

Copy link

Newest code from mattermost has been published to preview environment for Git SHA eee8ead

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 214395c

Copy link
Contributor

@esarafianou esarafianou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carrie!

@cwarnermm cwarnermm added this to the v10.5.0 milestone Feb 10, 2025
Copy link
Member

@JulienTant JulienTant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @cwarnermm !

@JulienTant JulienTant removed the 1: Dev Review Requires review by a core commiter label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants