Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Access conversations with deactivated users #7475

Conversation

TomerPacific
Copy link
Contributor

Summary

This pull request includes changes to the source/collaborate/channel-types.rst file to improve the clarity and structure of the documentation for direct and group messages. The key changes involve replacing .. tip:: with .. note:: and adding information about message history with deactivated users.

Ticket Link

Resolves #7425

… conversations with deactivated users and formating into one note
@mattermost-build
Copy link
Contributor

Hello @TomerPacific,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm self-requested a review October 11, 2024 20:19
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 11, 2024
Copy link

Newest code from TomerPacific has been published to preview environment for Git SHA c3390e1

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
Copy link

Newest code from TomerPacific has been published to preview environment for Git SHA fae2b75

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TomerPacific!

@cwarnermm cwarnermm added QA-wanted and removed 2: Editor Review Requires review by an editor labels Oct 16, 2024
@Rutam21
Copy link
Contributor

Rutam21 commented Oct 16, 2024

@lindy65 Please assign this PR to me for QA Testing. Thanks.

@lindy65
Copy link
Contributor

lindy65 commented Oct 16, 2024

Thanks, assigned to you @Rutam21

@lindy65 lindy65 added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 16, 2024
Copy link

Newest code from TomerPacific has been published to preview environment for Git SHA d9b5cbb

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 16, 2024

The changes in this PR have been tested in the preview environment and all the required changes are available in the mentioned pages.

  • The Direct Messages and Group Messages Note sections contain a new bullet point with the required information.
  • The link in the text unless your system admin disables your ability to do so for that specific bullet point is working fine and points to the correct place in the Docs.

I've attached a video as a confirmation.

PR-7475.QA.Testing.mp4

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 17, 2024

Thank you @Rutam21 - counted towards Hacktoberfest!

cc @cwarnermm

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 17, 2024
@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 17, 2024
@cwarnermm cwarnermm merged commit 9c511af into mattermost:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Access conversations with deactivated users
5 participants