Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for S3 storage classes #7467

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add documentation for S3 storage classes #7467

wants to merge 4 commits into from
+42 −0

Conversation

NadavTasher
Copy link

Summary

Added documentation about S3 storage classes.

This is a supplementary PR for mattermost/mattermost#28319

Ticket Link

mattermost/mattermost#28319

@mattermost-build
Copy link
Contributor

Hello @NadavTasher,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@NadavTasher NadavTasher mentioned this pull request Oct 9, 2024
Merged
@cwarnermm cwarnermm self-requested a review October 10, 2024 12:53
@cwarnermm cwarnermm added Do Not Merge Should not be merged until this label is removed 2: Editor Review Requires review by an editor labels Oct 10, 2024
@cwarnermm
Copy link
Member

Requires mattermost/mattermost#28319 to be merged.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm cwarnermm removed the Hacktoberfest null label Nov 1, 2024
@NadavTasher NadavTasher force-pushed the feature/add-s3-storage-class-documentation branch from d09c9a3 to bf64d15 Compare November 6, 2024 20:18
@NadavTasher
Copy link
Author

Hi, the PR in question was approved, shall we proceed with this documentation PR?

@NadavTasher
Copy link
Author

mattermost/mattermost#28319 was merged.

@cwarnermm cwarnermm added this to the v10.4.0 milestone Nov 14, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm
Copy link
Member

Hi @NadavTasher - Yes, we'll be moving forward with this docs PR as part of the Mattermost v10.4 release given that mattermost/mattermost#28319 is scheduled for release in v10.4. Really appreciate your help with this!

@NadavTasher
Copy link
Author

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm Awaiting requested review from cwarnermm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2: Editor Review Requires review by an editor Contributor Do Not Merge Should not be merged until this label is removed
Projects
None yet
Milestone
v10.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NadavTasher @mattermost-build @cwarnermm