Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac build again 😭 #3281

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix mac build again 😭 #3281

merged 2 commits into from
Jan 10, 2025

Conversation

devinbinnie
Copy link
Member

@devinbinnie devinbinnie commented Jan 9, 2025 •
edited
Loading

Summary

Fix mac build again 😢

NONE

@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed release-note-none labels Jan 9, 2025
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 9, 2025
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 10, 2025
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 10, 2025
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 10, 2025
@devinbinnie devinbinnie changed the title Fix mac build again Fix mac build again 😢 Jan 10, 2025
@devinbinnie devinbinnie changed the title Fix mac build again 😢 Fix mac build again 😭 Jan 10, 2025
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 10, 2025
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 10, 2025
@devinbinnie devinbinnie marked this pull request as ready for review January 10, 2025 17:37
@devinbinnie devinbinnie requested review from marianunez and removed request for marianunez January 10, 2025 17:37
@devinbinnie devinbinnie enabled auto-merge (squash) January 10, 2025 17:38
@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Jan 10, 2025
larkox
larkox approved these changes Jan 10, 2025
View reviewed changes
electron-builder.json Show resolved Hide resolved
@devinbinnie devinbinnie merged commit b6bbfea into master Jan 10, 2025
29 checks passed
@devinbinnie devinbinnie deleted the fix_mac_build_again branch January 10, 2025 17:42
@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@marianunez marianunez marianunez approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Build Apps for PR Builds signed builds for testing release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devinbinnie @marianunez @larkox @mm-cloud-bot