[MM-62094] E2E: Don't including loading screen or other windows in server map, remove check for loading screen finish #3252
+110
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit e7fed2fNew failed tests found on Linux:
Test Summary for macOS on commit e7fed2fNew failed tests found on macOS:
Test Summary for Windows on commit e7fed2fNew failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
devinbinnie
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 9fdd96eNew failed tests found on Linux:
Test Summary for macOS on commit 9fdd96eNew failed tests found on macOS:
Test Summary for Windows on commit 9fdd96eNew failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
devinbinnie
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit ad4b160New failed tests found on Linux:
Test Summary for macOS on commit ad4b160New failed tests found on macOS:
Test Summary for Windows on commit ad4b160New failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
devinbinnie
force-pushed
the
MM-62094
branch
from
ad4b160 to
1d2f65e
Compare
devinbinnie
added
the
Run Desktop E2E Tests
devinbinnie
added
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 1d2f65eNew failed tests found on Linux:
Test Summary for macOS on commit 1d2f65eNew failed tests found on macOS:
Test Summary for Windows on commit 1d2f65eNew failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 67c8995New failed tests found on Linux:
Test Summary for macOS on commit 67c8995New failed tests found on macOS:
Test Summary for Windows on commit 67c8995New failed tests found on Windows:
|
|
/update-branch |
|
/update-branch |
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 945c1bfNew failed tests found on Linux:
Test Summary for macOS on commit 945c1bfNew failed tests found on macOS:
Test Summary for Windows on commit 945c1bfNew failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit b541bc5New failed tests found on Linux:
Test Summary for macOS on commit b541bc5New failed tests found on macOS:
Test Summary for Windows on commit b541bc5New failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 4fb5d82New failed tests found on Linux:
Test Summary for macOS on commit 4fb5d82New failed tests found on macOS:
Test Summary for Windows on commit 4fb5d82New failed tests found on Windows:
|
github-actions
bot
removed
the
Run Desktop E2E Tests
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit 5f36d80New failed tests found on Linux:
Test Summary for macOS on commit 5f36d80All stable tests passed on macOS. Test Summary for Windows on commit 5f36d80All stable tests passed on Windows. |
github-actions
bot
removed
the
Run Desktop E2E Tests
yasserfaraazkhan
approved these changes
Jan 28, 2025
yasserfaraazkhan
approved these changes
Jan 28, 2025
|
/update-branch |
marianunez
approved these changes
Jan 30, 2025
M-ZubairAhmed
approved these changes
Jan 31, 2025
Comment on lines
+271
to
+283
| switch (process.platform) { | ||
| case 'darwin': | ||
| username = '[email protected]'; | ||
| break; | ||
| case 'linux': | ||
| username = '[email protected]'; | ||
| break; | ||
| case 'win32': | ||
| username = '[email protected]'; | ||
| break; | ||
| default: | ||
| throw new Error('Unsupported platform'); | ||
| } |
There was a problem hiding this comment.
Why do we need to hardcode these usernames and for each platform?
There was a problem hiding this comment.
Hi @saturninoabril
This is a temp fix untill we have a support to spin up a server on run time and destroying it.
Since we use same user account and 1 instance, we end up running same tests in parallel on 3 OS. There are quite few tests that fail as they interact with default channel or slash command or assert text posted during other OS test is running. To avoid that I have created these on the /cloud instance we use to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Checklist
npm run lint:jsfor proper code formattingRun Desktop E2E TestsDevice Information
This PR was tested on:
Screenshots
Release Note