[MM-62029] Require MSIINSTALLPERUSER for auto update to work #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
requested review from
a team and
harshilsharma63
and removed request for
a team
devinbinnie
requested review from
a team,
gabrieljackson and
Rajat-Dabade
and removed request for
harshilsharma63 and
a team
Rajat-Dabade
approved these changes
Dec 6, 2024
Rajat-Dabade
added
4: Reviews Complete
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Devin Binnie <[email protected]>
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
* [MM-61994] Fix UpgradeCode to use the old one, allow MSI to uninstall both (#3237) Co-authored-by: Devin Binnie <[email protected]> * [MM-62029] Require MSIINSTALLPERUSER for auto update to work (#3239) Co-authored-by: Devin Binnie <[email protected]> * [MM-60416] Check for the presence of the EXE uninstaller before trying to run it (#3238) Co-authored-by: Devin Binnie <[email protected]> --------- Co-authored-by: Devin Binnie <[email protected]>
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Devin Binnie <[email protected]>
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
* [MM-61994] Fix UpgradeCode to use the old one, allow MSI to uninstall both (#3237) Co-authored-by: Devin Binnie <[email protected]> * [MM-62029] Require MSIINSTALLPERUSER for auto update to work (#3239) Co-authored-by: Devin Binnie <[email protected]> * [MM-60416] Check for the presence of the EXE uninstaller before trying to run it (#3238) Co-authored-by: Devin Binnie <[email protected]> --------- Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The auto updater was not taking into account another MSI parameter that determines per-user installation,
MSIINSTALLPERUSER, which by default is set to 1, but other deployment systems might use this to set per-user installation.This PR makes sure that parameter is taken into account.
Ticket Link
https://mattermost.atlassian.net/browse/MM-62029