[MM-61994] Fix UpgradeCode to use the old one, allow MSI to uninstall both #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
requested review from
a team and
sbishel
and removed request for
a team
harshilsharma63
approved these changes
Dec 4, 2024
sbishel
approved these changes
Dec 4, 2024
devinbinnie
added
4: Reviews Complete
6 tasks
|
/cherry-pick release-5.10 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Dec 9, 2024
… both (#3237) Co-authored-by: Devin Binnie <[email protected]> (cherry picked from commit c08b1f3)
mattermost-build
added
the
CherryPick/Done
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
… both (#3237) Co-authored-by: Devin Binnie <[email protected]>
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
* [MM-61994] Fix UpgradeCode to use the old one, allow MSI to uninstall both (#3237) Co-authored-by: Devin Binnie <[email protected]> * [MM-62029] Require MSIINSTALLPERUSER for auto update to work (#3239) Co-authored-by: Devin Binnie <[email protected]> * [MM-60416] Check for the presence of the EXE uninstaller before trying to run it (#3238) Co-authored-by: Devin Binnie <[email protected]> --------- Co-authored-by: Devin Binnie <[email protected]>
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
… both (#3237) Co-authored-by: Devin Binnie <[email protected]>
devinbinnie
added a commit
that referenced
this pull request
Dec 9, 2024
* [MM-61994] Fix UpgradeCode to use the old one, allow MSI to uninstall both (#3237) Co-authored-by: Devin Binnie <[email protected]> * [MM-62029] Require MSIINSTALLPERUSER for auto update to work (#3239) Co-authored-by: Devin Binnie <[email protected]> * [MM-60416] Check for the presence of the EXE uninstaller before trying to run it (#3238) Co-authored-by: Devin Binnie <[email protected]> --------- Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An issue with the newer MSI installer (present since v5.9) was that it would not uninstall previous versions installed by the old MSI installer. This was due to a change in the
UpgradeCode, which was manually created for the old MSI, and automatically generated byelectron-builderfor the new one.electron-builderdid support a way to prescribe it, but I had missed adding that.This PR both adds the original
UpgradeCodethat we used from the old MSI, as well as adds another step to the new installer that will uninstall versions v5.9 and v5.10 that used the auto-generatedUpgradeCode. This alongside the script that uninstalls the EXE should make sure the app uninstalls all other versions of the Desktop App before proceeding to install the new one.Ticket Link
https://mattermost.atlassian.net/browse/MM-61994