-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-62001] Calls: switch tab on actions requiring focus #3235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean, thanks! And thanks for the great tests!
@DHaussermann Left some test steps in the ticket. Let me know if you need more info. |
@streamer45 I have done a round of testing on this and the issue as described is resolved. But I think something might be going wrong here. The widget aside, I see an issue where the screen share option is no longer working from the expanded view. Not 100% sure this was in scope but, I can't repro the issue on our production build. I don't just mean for switching tabs if needed. For me the share button no longer works from any tab. Can you please see if you can repo this? (I have only tried on Mac)
|
@DHaussermann It sounds like you may be hitting https://mattermost.atlassian.net/browse/MM-62241, which was reported by @matthewbirtch as well during testing of #3253 I'll look at that separately since it's not related to these PRs as far as I can tell. |
Ah of course! Thanks @streamer45! This does seem like the issue I'm seeing. It seemed strange and as they both relate to screen share it seemed plausible it was from this PR 🙃. |
Absolutely! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Confirmed issue is resolved. Screen share from widget is functional and will flip to channels tab if needed
- Confirmed other options that need to flip to channels tab such as setting are also functional if you're on a different tab
- Regression tested other action in the widget that do not require flipping tabs
LGTM!
Issue with screen share via expanded view will be addressed separately.
Summary
For calls widget actions requiring focus on the main channel view (e.g., channel link click, showing screen sharing selection modal), we were not handling the possibility that the tab was something other than messaging. We fix this by switching to the expected tab.
Ticket Link
https://mattermost.atlassian.net/browse/MM-62001
Release Note