Fixed issues with loading the app from cold when deep linking #3201
Conversation
|
@amyblais This might be a case for a dot release for v5.10 - as the app is somewhat unusable when users get into this state. The server will load on v5.10, but the dropdown fails. |
amyblais
added
the
CherryPick/Approved
| MainWindow.show(); | ||
| ViewManager.handleDeepLink(deeplinkingUrl); | ||
| } else { | ||
| MainWindow.on(MAIN_WINDOW_CREATED, () => ViewManager.handleDeepLink(deeplinkingUrl)); |
There was a problem hiding this comment.
Are there any race conditions at play? (Could MainWindow get created between our get and on registration?
There was a problem hiding this comment.
Well I went to go double-check, I found another instance where we're calling show() before app.ready() which is really not good.
However, other callers of this are also waiting for the ready event, so as long as we're calling it after that there shouldn't be any race conditions as that's when we expect the window to be registered.
The ready event docs if you're interested: https://www.electronjs.org/docs/latest/api/app#event-ready
devinbinnie
added
3: QA Review
yasserfaraazkhan
added
the
Run Desktop E2E Tests
|
Here are the test results below: Test Summary for Linux on commit d0355cbThe following known failed tests have been fixed on Linux: Test Summary for macOS on commit d0355cbThe following known failed tests have been fixed on macOS: |
github-actions
bot
removed
the
Run Desktop E2E Tests
amyblais
added
4: Reviews Complete
|
Cherry pick is scheduled. |
* Fixed issues with loading the app from cold when deep linking * Don't call show() before the window is created on Windows (cherry picked from commit 1fe94eb)
mattermost-build
added
CherryPick/Done
…#3205) * Fixed issues with loading the app from cold when deep linking * Don't call show() before the window is created on Windows (cherry picked from commit 1fe94eb) Co-authored-by: Devin Binnie <[email protected]>
Summary
While working on #3200 I found an issue with deep linking when booting the app from cold. The application would fail to load the initial server, and the dropdown menu would also not load. This was caused by the main window creation call happening too early, before a bunch of other setup code could be run.
This PR fixes the issue by having the application wait for the main window to be created normally, before attempting to deep link.