-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Digest Mismatch error on Enterprise Linux installations when FIPS… #3194
Conversation
Hello @jonathan-dove, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jonathan-dove!
@toninis Can you check to make sure this doesn't harm our RPM build process? |
@devinbinnie I need to manually build a rpm package from this PR and test that so this needs to wait a bit . |
Yep we can test locally whenever you have time. Let's do that before we merge. If I can be of help let me know. |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
@toninis Any progress on locally testing this? |
@devinbinnie I tested the rpm locally and installs . This change only affects the checksum . Once merged we will also check the nightly build repo |
/update-branch |
@toninis Feel free to approve if you think it's ready to merge. |
Summary
Added fpm argument to the package.json file to change the hashing algorithm from md5 to sha256. This fixes an issue introduced in RHEL8+ and/or clones where if FIPS mode is enabled rpm digests must be hashed with at minimum sha256 to be allowed to be installed without bypassing security measures put in place by the FIPS standards.
Ticket Link
#3190
Checklist
npm run lint:js
for proper code formattingDevice Information
This PR was tested on: RHEL 8, RHEL 9, Rocky9, Rocky8
Release Note