-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-59483] Remove legacy preload and custom login code #3174
Conversation
@yasserfaraazkhan We can test this whenever, but since we're removing support for older versions, we should double check that the versions we support are all working well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with servers
- v9.5 ✅
- v9.4 ✅
- v9.2 & v9.0 the login flow was stuck and in logs we can see error
[TAB_MESSAGING] Cannot reach server: Error: net::ERR_CONNECTION_REFUSED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up. I am assuming the failing Electron Playwright Tests
is expected or being worked on separately?
Summary
This PR removes code in the Desktop App that was left to support older versions of the Mattermost Server/Web App:
window.postMessage
, needed for server versions <v9.4What this does mean is that as of this change, Mattermost servers running versions under v9.4 will now have a reduced experience, and may or may not function at all. We will be dropping support for those server versions in the Desktop App officially as of v5.11.
This is being done to both reduce complication, improve security (in the case of custom logins) and potentially improve performance (in the case of the preload script changes)
Ticket Link
https://mattermost.atlassian.net/browse/MM-59843