Removing empy zh_Han* files that are raising an alert in Weblate #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ctlaltdieliet, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
devinbinnie
approved these changes
Oct 19, 2023
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
@ctlaltdieliet Am I good to merge this? |
|
@devinbinnie yes this is safe to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With moving the WIP-languages to the shipped project, we got duplicate files for Traditional and Simplified Chinese.
Although zh_Hans and zh_Hant are more correct, it would require code-changes and existing Chinese users to chose their language again.
As these filenames are not visible, we can keep using these
Screenshots
Release Note