-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-85,84,71,49] (WIP)Confluence Phase-2 #88
base: master
Are you sure you want to change the base?
[GH-85,84,71,49] (WIP)Confluence Phase-2 #88
Conversation
* MI-1721: WIP * MI-1721: WIP * MI-1721: Fixed GetClient function * MI-1721: WIP * [MI-1751]:Added Logic to create webhook for connecting to confluence server * MI-1721: Added OAuth2.0 for confluence server and cloud * MI-1721: Done some code refactoring * [MI-1772]:WIP:Working on Notifications * [MI-1751]:Fixed Review fixes * [MI-1751]:[WIP]:Added Notifications for server * [MI-1772]:[WIP]:refactoring code * [MI-1772]:Fixed Self Review fixes * [MI-1772]:Fixed Review fixes * [MI-1794][WIP]:Added Notifications for Confluence Cloud * [MI-1794]:Added Confluence Cloud Notification * [MI-1794]:Self review fixes * [MI-1788]:Completed Notifications for Confluence Server * [MI-1788]:Self Review Fixes * [MI-1811]:Fixed Unsubscribe command * [MI-1811]:Self review fixes * [MI-1814]:Added /edit Command in confluence Plugin * [MI-1794]:Fixed Review fixes * [MI-1822][WIP]:wrote some test cases * [MI-1826]:Added Permissions for who can create/edit/delete the subscriptions * [MI-1826]:Fixed review fixes * [MI-1788]:Fixed Review fixes * [MI-1811]:Fixed review fixes * [MI-1788]:Removed Kv store Admin Funtions * [MI-1814]:Fixed review fixes * [MI-1822]:Updated the test cases * [MI-1834][WIP]:Fixing bugs * [MI-1834]:self review fixes * [MI-1834]:review fixes done * [MI-1826]:review fixes done * [MI-1814]:review fixes done * [MI-1811]:review fixes done * [MI-1842]:Added test cases for Oauth flow * [MI-1842]:self review fixes * [MI-1842]:added yml files * [MI-1721]:fixed review fixes * [MI-1849]:fixed bug fixes * [MI-1849]:fixed templates * [MI-1849]:fixed review fixes * [MI-1853]:fixed linting errors * [MI-1853]:Fixed and removed lint erros * [MI-1853]:self review fixes * [MI-1853]:fixed linters in github actions * [MI-1853]:fixes goimports error * [MI-1853]:fix lint errors in webapp * [MI-1853]:fixed webapp test cases * [MI-1853]:Fixed circleCI error * [MI-1853]:fixed Circle lint error * [MI-1853]:Ran go mod tidy * [MI-1853]:fixed go.mod file * [MI-1853]:fixed go.mod and go.sum * [MI-1853]:fixed review fixes * [MI-1721]:fixed review fixes * [MI-1751]:Added Logic to create webhook for connecting to confluence server (#1) * [MI-1751]:Added Logic to create webhook for connecting to confluence server * [MI-1751]:Fixed Review fixes * [MI-1772]:Added logic for server side notifications for confluence (#3) * [MI-1772]:WIP:Working on Notifications * [MI-1751]:[WIP]:Added Notifications for server * [MI-1772]:[WIP]:refactoring code * [MI-1772]:Fixed Self Review fixes * [MI-1772]:Fixed Review fixes * [MI-1772]:fixed review fixes * [MI-1794]:Added Notifications for Confluence Cloud (#4) * [MI-1794][WIP]:Added Notifications for Confluence Cloud * [MI-1794]:Added Confluence Cloud Notification * [MI-1794]:Self review fixes * [MI-1794]:Fixed Review fixes * [MI-1794]:fixed review fixes * [MI-1794]:fixed review fixes * [MI-1788]:Created Notifications for Confluence Server(webhook per user) (#5) * [MI-1788]:Completed Notifications for Confluence Server * [MI-1788]:Self Review Fixes * [MI-1788]:Fixed Review fixes * [MI-1788]:Removed Kv store Admin Funtions * [MI-1811]:Added Logic for Unsubscribe Command (#6) * [MI-1811]:Fixed Unsubscribe command * [MI-1811]:Self review fixes * [MI-1811]:Fixed review fixes * [MI-1811]:review fixes done * [MI-1814]:Added /edit Command in confluence Plugin (#7) * [MI-1814]:Added /edit Command in confluence Plugin * [MI-1814]:Fixed review fixes * [MI-1814]:review fixes done * [MI-1814]:fixed review fixes * [MI-1822]:Updated the Test cases for Confluence Plugin (#9) * [MI-1822][WIP]:wrote some test cases * [MI-1822]:Updated the test cases * [MI-1822]:fixed review fixes * [MI-1822]:fixed review fixes Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: Shivam Chauhan <[email protected]> * [MI-1721]:fixed circle error * [MI-1721]:fixed frontend linters Co-authored-by: Kshitij Katiyar <[email protected]> Co-authored-by: kshitij katiyar <[email protected]>
@mkdbns I meant to mention you above |
@mickmister We can create 2 Incremental PRs one for auth/notification and one for create Page Module. As they are incremental and create page module is dependent on auth/notification and i can only 1 create PR here with a base branch of mattermost:master and the other one have to be internal as auth/notification Branch is not present in mattermost confluence repo. So should i create only 1 PR and wait for it to merge or should i create 1 branch with mattermost master and other as a internal PR on brightscout domain but that will be on a public forked repo . |
@Kshitij-Katiyar Let's have the auth/notification PR be merged, and then have the create page module PR submitted. We can use this open PR as the create page PR if the git history makes sense for that. |
@mickmister Create a PR for auth/notifications .Please find the at following link :- #89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I made a first sweep to the backend, I couldn't review the frontend yet, but It might have been nice to split these in the future, there are some strategies (creating a feature per PR, splitting front and back, ...)
Not sure if we will review everything on #89, just in case let's check there also when there are new changes. |
@javaguirre I will be fixing all the above review comments in the PR #89 as that is the latest PR containing features like config manipulation through slash commands and migrations of subscriptions. All the code present in this is present in PR 89 apart from 1 feature (Create confluence page using mattermost) This PR is here only for reference. |
Thank you for pointing that out! 💯 Please, let me know when to review. |
@Kshitij-Katiyar Heads up that there are merge conflicts to resolve |
@hanzei Please read this comment #88 (comment) ,#88 (comment) and #88 (comment). This PR is a Draft PR I am not able to convert it to Draft for some reason, that's why added WIP in the title. Please see #89 |
Summary and Features Added:-
Removed the dependency on the Confluence-side plugin (OBR file) to support subscriptions on Confluence Server/Data Center.
Added support for OAuth 2.0 for both Cloud and Server editions of Confluence . Users can OAuth using /Confluence connect command.
Remove the need to use a single shared authentication token limiting subscriptions to
admins only.
In case of subscriptions ,users can only subscribe to spaces and pages that their Confluence
account has access to.
Support of following events is there:-
• space_updated
• page_created
• page_restored
• page_trashed
• page_updated
• comment_created
• comment_updated
Added permissions for both Mattermost and confluence side which can be changed by Mattermost Admin in Plugin configuration.
Create Page through Mattermost on Confluence both for server as well as cloud
i) A Post Dropdown Menu Action to create a new confluence page
ii) Opens a modal that with following options:-
• Confluence URL
• Space Key/Name
• Page Title
• Page body text which shall be pre-populated with the post content
iii) Once the new page is created, It will also post a notification of the new page in the channel that from which the page
was created.