Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go-funk dependency #116

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Remove go-funk dependency #116

merged 5 commits into from
Dec 3, 2024

Conversation

mickmister
Copy link
Contributor

Dependabot opened a PR to update this dependency #112 (comment), and it is only being used for a simple utility function so I removed the dependency instead of updating it

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

server/service/notification.go Outdated Show resolved Hide resolved
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Jul 4, 2024
@hanzei hanzei added this to the v1.4.0 milestone Dec 3, 2024
@hanzei hanzei merged commit 8571cb2 into master Dec 3, 2024
3 checks passed
@hanzei hanzei deleted the remove-go-funk-dep branch December 3, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants