Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI in oz audit sep head #939

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

StanislavBreadless
Copy link
Collaborator

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

github-actions bot commented Oct 15, 2024

Changes to gas cost

Generated at commit: 326abaf9e756ab08dc329bd51493e49e461b0c82, compared to commit: 82084025addb869fed85b10e627aa4754cc6b9c0

🧾 Summary (100% most significant diffs)

Contract Method Avg (+/-) %
TransparentUpgradeableProxy getHyperchain
setAllowedData
validatorTimelock
-2,500 ✅
+57 ❌
-625 ✅
-53.18%
+0.10%
-10.71%
DummyBridgehubSetter createNewChain
requestL2TransactionDirect
requestL2TransactionTwoBridges
setCTM
setZKChain
-1,408 ✅
-35 ✅
+15 ❌
0 ➖
0 ➖
-1.32%
-0.04%
+0.01%
0.00%
0.00%
ChainAdmin setUpgradeTimestamp -77 ✅ -0.17%
DiamondProxy requestL2Transaction -4 ✅ -0.00%
PermanentRestriction setAllowedData +20 ❌ +0.07%
TestnetERC20Token transfer -13 ✅ -0.03%
DummyChainTypeManagerWBH setZKChain +3 ❌ +0.01%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
TransparentUpgradeableProxy 787,868 (0) allowAdminImplementation
getHyperchain
setAllowedData
setSelectorIsValidated
validatorTimelock
54,635 (0)
2,201 (-2,500)
55,335 (-429)
54,680 (0)
960 (0)
0.00%
-53.18%
-0.77%
0.00%
0.00%
54,882 (-12)
2,201 (-2,500)
56,396 (+57)
54,710 (-2)
5,210 (-625)
-0.02%
-53.18%
+0.10%
-0.00%
-10.71%
55,007 (0)
2,201 (-2,500)
55,992 (0)
54,728 (0)
5,210 (-1,250)
0.00%
-53.18%
0.00%
0.00%
-19.35%
55,007 (0)
2,201 (-2,500)
58,155 (+12)
54,728 (0)
9,460 (0)
0.00%
-53.18%
+0.02%
0.00%
0.00%
258 (0)
24 (0)
257 (0)
258 (0)
4 (0)
DummyBridgehubSetter 5,364,532 (0) addChainTypeManager
admin
createNewChain
proveL1ToL2TransactionStatus
proveL2LogInclusion
proveL2MessageInclusion
removeChainTypeManager
requestL2TransactionDirect
requestL2TransactionTwoBridges
setCTM
setPendingAdmin
setZKChain
23,865 (0)
411 (0)
28,739 (-228)
0 (0)
0 (0)
0 (0)
23,802 (0)
32,902 (-36)
30,887 (+12)
44,193 (0)
25,880 (0)
111,315 (0)
0.00%
0.00%
-0.79%
+∞%
+∞%
+∞%
0.00%
-0.11%
+0.04%
0.00%
0.00%
0.00%
44,089 (+1)
1,522 (-1)
105,190 (-1,408)
1,360 (+21)
1,442 (+3)
1,542 (-59)
25,421 (+7)
90,173 (-35)
134,149 (+15)
44,231 (0)
47,582 (-10)
111,353 (0)
+0.00%
-0.07%
-1.32%
+1.57%
+0.21%
-3.69%
+0.03%
-0.04%
+0.01%
0.00%
-0.02%
0.00%
47,558 (0)
2,411 (0)
36,331 (-12)
961 (0)
1,063 (+3)
1,147 (0)
25,774 (0)
73,793 (-1,587)
56,978 (-900)
44,241 (-12)
49,745 (0)
111,363 (-12)
0.00%
0.00%
-0.03%
0.00%
+0.28%
0.00%
0.00%
-2.11%
-1.55%
-0.03%
0.00%
-0.01%
47,558 (0)
2,411 (0)
885,415 (+18,389)
3,585 (+7)
3,792 (0)
3,941 (-21)
26,190 (0)
199,886 (-2,523)
359,701 (-168)
44,253 (0)
49,757 (0)
111,375 (0)
0.00%
0.00%
+2.12%
+0.20%
0.00%
-0.53%
0.00%
-1.25%
-0.05%
0.00%
0.00%
0.00%
6,656 (0)
2,304 (+2)
2,560 (0)
512 (0)
512 (0)
512 (0)
2,048 (0)
1,024 (0)
1,536 (+1)
2,816 (0)
4,864 (+2)
2,816 (0)
MailboxFacet 3,287,412 (0) finalizeEthWithdrawal 8,101 (0) 0.00% 48,958 (+123) +0.25% 49,490 (0) 0.00% 49,490 (0) 0.00% 257 (0)
ChainAdmin 909,847 (0) setUpgradeTimestamp 25,361 (0) 0.00% 45,080 (-77) -0.17% 45,333 (+12) +0.03% 45,645 (0) 0.00% 256 (0)
DiamondProxy 2,475,597 (0) finalizeEthWithdrawal
requestL2Transaction
util_setChainId
37,590 (0)
33,146 (0)
28,906 (0)
0.00%
0.00%
0.00%
76,255 (+117)
128,877 (-4)
33,771 (+4)
+0.15%
-0.00%
+0.01%
76,755 (0)
166,296 (-12)
33,718 (0)
0.00%
-0.01%
0.00%
77,007 (0)
188,247 (0)
34,090 (0)
0.00%
0.00%
0.00%
257 (0)
771 (0)
519 (0)
PermanentRestriction 1,998,755 (0) setAllowedData 26,762 (-271) -1.00% 27,205 (+20) +0.07% 27,033 (0) 0.00% 27,846 (0) 0.00% 257 (0)
L1NativeTokenVault 3,828,533 (0) bridgeBurn 12,557 (0) 0.00% 68,963 (+23) +0.03% 79,756 (0) 0.00% 79,756 (0) 0.00% 1,297 (0)
TestnetERC20Token 800,383 (0) transfer 46,273 (0) 0.00% 46,627 (-13) -0.03% 46,561 (-36) -0.08% 46,873 (0) 0.00% 257 (0)
AccessControlRestriction 1,759,691 (0) grantRole
setRequiredRoleForCall
51,036 (0)
48,605 (0)
0.00%
0.00%
51,277 (+3)
49,421 (-7)
+0.01%
-0.01%
51,408 (0)
48,977 (0)
0.00%
0.00%
51,408 (0)
51,877 (0)
0.00%
0.00%
1,024 (0)
1,280 (0)
DummyChainTypeManagerWBH 4,576,779 (0) setZKChain 44,085 (0) 0.00% 44,123 (+3) +0.01% 44,145 (+24) +0.05% 44,145 (0) 0.00% 256 (0)

@StanislavBreadless StanislavBreadless merged commit d158962 into oz-audit-sep-head Oct 16, 2024
24 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-fix-oz-audit-head-ci branch October 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant