Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kl/h02-2gw double deposit error #895

Open
wants to merge 4 commits into
base: gw-audit-2-fixes
Choose a base branch
from
Open

fix: kl/h02-2gw double deposit error #895

wants to merge 4 commits into from

Conversation

kelemeno
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@StanislavBreadless
Copy link
Collaborator

#866 (review)

WDYT about this comment btw? @kelemeno

@kelemeno
Copy link
Contributor Author

makes sense

@kelemeno
Copy link
Contributor Author

I think to provide better clarity wrt to the datahash, we can use the DataEncoding library in both places. Most probably the fact that the raw keccak256(abi.encode(_originalCaller, _l1Token, _amount)) is actually a hash of the legacy encoding may not be obvious + less code repetition means less mistakes

What are the two places, L1AssetRouter depositLEgacyERC20Bridge and?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok vladbochok left review comments

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelemeno @StanislavBreadless @vladbochok