Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drt: streamline constraints and update separation of soft vs hard constraint handling #3652

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nkuehnel
Copy link
Member

@nkuehnel nkuehnel commented Jan 3, 2025

  • streamlined constraints
    -- extended DrtRouteConstraints to include the late diversion and pickup delay constraints, which can now be set per request
    -- re-use the immutable constraints object in the DrtRoute class to avoid unneccessary duplication
    -- updated the handling of route description json-ification (@steffenaxer ?) to have a nested constraints representation. not sure how stable that is for future udpates
    -- we could think about further re-using the constraints object in the drt request object itself
  • separated the max ride duration, late pickup and diversion threshold constraints in the handling of the cost calculation. until now these three constraints will always lead to rejection even if rejection for soft constraints is turned off

@nkuehnel nkuehnel changed the title Drt: streamline constraints and separate soft vs hard constraint handling Drt: streamline constraints and update separation soft vs hard constraint handling Jan 3, 2025
@nkuehnel nkuehnel changed the title Drt: streamline constraints and update separation soft vs hard constraint handling Drt: streamline constraints and update separation of soft vs hard constraint handling Jan 3, 2025
@steffenaxer
Copy link
Collaborator

As far as I can remember, the description elements are needed within pricing context. Especially the unshared route length and optionally the unshared link sequence might be required. Anyway as long as those elements are available things should work. Thanks @nkuehnel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants