chore: Use default-features = false for most dependencies
#6104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6104 +/- ##
==========================================
- Coverage 89.84% 89.84% -0.01%
==========================================
Files 363 363
Lines 100638 100638
Branches 100638 100638
==========================================
- Hits 90420 90416 -4
- Misses 6690 6694 +4
Partials 3528 3528 ☔ View full report in Codecov by Sentry. |
This patch adds `default-features = false` to all dependencies to avoid fetching useless dependencies by default. Numbers: - `cargo check --workspace --tests` jumpbs from 725 to 715, - `cargo tree --all-features --edges all --prefix none | rg -v '^$' | cut -d' ' -f 1 | sort | uniq | wc -l` jumps from 538 to 529.
Not only it uses the same version of `clap` everywhere, but it removes 7 dependencies.
`indoc` is used once to declare a string, but it's easily doable with pure Rust without too much boilerplate. Let's remove one macro dep.
Hywan
changed the title
default-features = false for all dependenciesdefault-features = false for most dependencies
Hywan
force-pushed
the
chore-deps-no-default-features
branch
from
082543b to
5e1bdc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
default-features = falseto all dependencies to avoid fetching useless dependencies by default.One dependency is also removed, and a couple are updated.
Numbers:
cargo check --workspace --testsjumps from 725 to 710,cargo tree --all-features --edges all --prefix none | rg -v '^$' | cut -d' ' -f 1 | sort | uniq | wc -ljumps from 538 to 529.There is a bit more work for the
matrix-sdkcrate, but I want to tackle them separately.