Support TLS v1.3 on all platforms #6053
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this pull request should not be merged until
oauth2-rssupportsreqwest^0.13- i.e., when ramosbugs/oauth2-rs#334 is merged!Overview
The primary change in this pull request upgrades the
reqwestdependency to its latest version, which defaults to usingrustlswith support forrustls-platform-verifierinstead ofnative-tls(see[email protected]). The benefit here is thatrustlssupports TLS v1.3 on all platforms, whereasnative-tlsdoes not.This will be particularly helpful with element-hq/element-x-ios#786.
Changes
reqwestbumped to0.13.1HttpSettings::make_clientoauth2bumped to5.1.0reqwest^0.13Cargo.toml, which will be removed once Bump reqwest to 0.13 and raise MSRC to 1.71 ramosbugs/oauth2-rs#334 is merged and released!getrandombumped to0.3.4[email protected]proptestbumped to1.9.0[email protected]Thoughts
A number of feature flags have been replaced in the dependencies above.
reqwest/rustls-tls=>reqwest/rustls- this is simply a name change, but is semantically identical (see[email protected]).getrandom/js=>getrandom/wasm_js- the semantics here have changed slightly, but it seems to just make it easier to enable thewasm_jsbackend (see[email protected]).At any rate, I have updated references to these flags in each of the various
Cargo.tomlfiles, but have not changed the names of our exposed features to mimic those in the dependencies.Any thoughts or preferences on whether to mirror those names? That would, of course, result in a breaking change.
Fixes #5800.
Signed-off-by: Michael Goldenberg [email protected]