Skip to content

Conversation

@mgoldenberg
Copy link
Contributor

@mgoldenberg mgoldenberg commented Jan 20, 2026

NOTE: this pull request should not be merged until oauth2-rs supports reqwest^0.13 - i.e., when ramosbugs/oauth2-rs#334 is merged!

Overview

The primary change in this pull request upgrades the reqwest dependency to its latest version, which defaults to using rustls with support for rustls-platform-verifier instead of native-tls (see [email protected]). The benefit here is that rustls supports TLS v1.3 on all platforms, whereas native-tls does not.

This will be particularly helpful with element-hq/element-x-ios#786.

Changes

  • reqwest bumped to 0.13.1
    • The API for adding/replacing certificates has changed a bit, so this required some updating in HttpSettings::make_client
  • oauth2 bumped to 5.1.0
  • getrandom bumped to 0.3.4
  • proptest bumped to 1.9.0

Thoughts

A number of feature flags have been replaced in the dependencies above.

  1. reqwest/rustls-tls => reqwest/rustls - this is simply a name change, but is semantically identical (see [email protected]).
  2. getrandom/js => getrandom/wasm_js - the semantics here have changed slightly, but it seems to just make it easier to enable the wasm_js backend (see [email protected]).

At any rate, I have updated references to these flags in each of the various Cargo.toml files, but have not changed the names of our exposed features to mimic those in the dependencies.

Any thoughts or preferences on whether to mirror those names? That would, of course, result in a breaking change.


Fixes #5800.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Michael Goldenberg [email protected]

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.99%. Comparing base (439fb9d) to head (c8baefa).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/http_client/native.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6053   +/-   ##
=======================================
  Coverage   88.98%   88.99%           
=======================================
  Files         359      359           
  Lines       99685    99684    -1     
  Branches    99685    99684    -1     
=======================================
+ Hits        88708    88712    +4     
+ Misses       6989     6983    -6     
- Partials     3988     3989    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing mgoldenberg:support-tls-1.3 (c8baefa) with main (a32c11f)

Open in CodSpeed

Signed-off-by: Michael Goldenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TLS 1.3 support

1 participant