Upgrade bindings to Rust edition 2024 #5308
Draft
+137
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like this is blocked on #5189, which is in turn blocked on matrix-org/complement-crypto#197. |
Contributor
|
This PR has bitrotten quite a bit, I think it should be unblocked now due to the various PRs being addressed. Feel free to reopen if you get it rebased. |
jplatte
force-pushed
the
jplatte/ffi-rust2024
branch
2 times, most recently
from
95e6b49 to
215f810
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5308 +/- ##
==========================================
- Coverage 88.94% 88.94% -0.01%
==========================================
Files 357 357
Lines 99111 99111
Branches 99111 99111
==========================================
- Hits 88155 88154 -1
- Misses 6977 6978 +1
Partials 3979 3979 ☔ View full report in Codecov by Sentry. |
jplatte
force-pushed
the
jplatte/ffi-rust2024
branch
from
215f810 to
5e27361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by NordSecurity/uniffi-bindgen-go#40.
Signed-off-by: Jonas Platte