Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(send queue): send attachments with the send queue #4195

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. chore(event cache store): Support multiple parent key types for depen…

    …dent requests
    
    This makes it possible to have different kinds of *parent key*, to
    update a dependent request. A dependent request waits for the parent key
    to be set, before it can be acted upon; before, it could only be an
    event id, because a dependent request would only wait for an event to be
    sent. In a soon future, we're going to support uploading medias as
    requests, and some subsequent requests will depend on this, but won't be
    able to rely on an event id (since an upload doesn't return an
    event/event id).
    
    Since this changes the format of `DependentQueuedRequest`, which is
    directly serialized into the state stores, I've also cleared the table,
    to not have to migrate the data in there. Dependent requests are
    supposed to be transient anyways, so it would be a bug if they were
    transient.
    
    Since a migration was needed anyways, I've also removed the `rename`
    annotations (that supported a previous format) for the
    `DependentQueuedRequestKind` enum.
    bnjbvr committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    10be327 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    6adc615 View commit details
    Browse the repository at this point in the history
  2. refactor!(event cache store): store the serialized `QueuedRequestKind…

    …`, not a raw event
    
    Changelog: The send queue will now store a serialized
     `QueuedRequestKind` instead of a raw event, which breaks the format.
     As a result, all send queues have been emptied.
    bnjbvr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5d3ed08 View commit details
    Browse the repository at this point in the history
  3. chore(event cache store): remove failing test

    Because the latest migration would clear events to-be-sent from the send
    queue, the test now failed. It's been considered OK.
    bnjbvr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2ab23b0 View commit details
    Browse the repository at this point in the history
  4. chore(base): refactor internal helpers related to media

    Notably, make it super clear what parameters are required to create the
    attachment type, since the function doesn't consume the whole
    `AttachmentConfig` for realz.
    bnjbvr committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9b197e2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd6402b View commit details
    Browse the repository at this point in the history