refactor(crypto)!: Remove unused OneTimeKey::Key and SessionCreationError::OneTimeKeyUnknown variants
#4194
+1
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecakeh
requested review from
jmartinesp and
richvdh
and removed request for
a team
poljar
approved these changes
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4194 +/- ##
==========================================
+ Coverage 84.89% 84.91% +0.02%
==========================================
Files 272 272
Lines 29142 29131 -11
==========================================
- Hits 24739 24738 -1
+ Misses 4403 4393 -10 ☔ View full report in Codecov by Sentry. |
…onError::OneTimeKeyUnknown` variants Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
rm-unsigned-otk
branch
from
7d6ea39
to
190fb3f
Compare
zecakeh
changed the title
OneTimeKey::Signed and SessionCreationError::OneTimeKeyUnknown variantsOneTimeKey::Key and SessionCreationError::OneTimeKeyUnknown variants
|
Oops, sorry about that. It's fixed now. |
poljar
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4171 (comment).